Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.60%. Comparing base (95881a0) to head (b3bccb6).
Report is 206 commits behind head on main.

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   85.59%   85.60%           
=======================================
  Files          26       26           
  Lines        2853     2882   +29     
  Branches      677      693   +16     
=======================================
+ Hits         2442     2467   +25     
- Misses        304      305    +1     
- Partials      107      110    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Very neat! I like how this also applies to everything that is serialized very elegantly.

I just tried this with the error I initially reported. Its a better error message for sure, but there is still some improvement possible :)

    builder.required_signers = ["string!"]

results in

TypeError: Field 'required_signers' should be of type typing.Union[typing.List[pycardano.hash.VerificationKeyHash], 
NoneType], got <class 'list'> instead.

The error here is that I have a list of "str" and not list of the required type, which upsets the type checker - it fails to point out the precise violation though.

I think the only reasonable fix for this would be a recursive type printer. Will look into that.

Suggestion: Instead of printing the type of the violating object (which may hide recursive errors), just print the violating value? This also helps the developer debug, as they might have a better grip on where a value comes from than what type it has.

Changes the error message to

TypeError: Field 'required_signers' should be of type typing.Union[typing.List[pycardano.hash.VerificationKeyHash], 
NoneType], got ['string!'] instead.